Skip to content

Improve tabs link support #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 14, 2025
Merged

Improve tabs link support #3211

merged 18 commits into from
May 14, 2025

Conversation

clairechabas
Copy link
Contributor

@clairechabas clairechabas commented May 5, 2025 •
edited
Loading

Reproducing headings hash links UX: show the hash link button on the left of tabs block when hovered. The URL hash will match the selected tab.

Move hash link button to its component for reusability and unifies its styles for all blocks for consistency.
Improve spacing on headings hash anchor link.

Preview

Active tab hovered
Screenshot 2025-05-09 at 17 23 37

Inactive tab hovered
Screenshot 2025-05-09 at 17 23 43

Heading 1 hovered
Screenshot 2025-05-09 at 17 22 52

Heading 2 hovered
Screenshot 2025-05-09 at 17 23 50

Heading 3 hovered
Screenshot 2025-05-09 at 17 23 02

@linear Linear
Copy link

linear bot commented May 5, 2025

RND-6959 Add support for tabs links in GBO

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fc39334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited
Loading

Summary of the deployments:

Version 1

Version URL Status
Latest commit https://79c3bd44.gitbook-open.pages.dev ✅
PR https://pr3211.gitbook-open.pages.dev ✅

Version 2

Version URL Status
Vercel https://gitbook-v2-kqv4wgqze-gitbook.vercel.app ✅
Cloudflare https://c8f602a6-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site v1 2v 2c
GitBook https://79c3bd44.gitbook-open.pages.dev/docs.gitbook.com https://gitbook-v2-kqv4wgqze-gitbook.vercel.app/url/docs.gitbook.com https://c8f602a6-gitbook-open-v2-preview.gitbook.workers.dev/url/docs.gitbook.com
E2E https://79c3bd44.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open https://gitbook-v2-kqv4wgqze-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://c8f602a6-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci Argos CI
Copy link

argos-ci bot commented May 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 4 changed May 14, 2025, 8:48 AM
customers-v2 (Inspect) 👍 Changes approved 4 changed May 14, 2025, 8:50 AM
default (Inspect) 👍 Changes approved 4 changed May 14, 2025, 8:51 AM
v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 4 changed May 14, 2025, 8:52 AM
v2-vercel (Inspect) 👍 Changes approved 8 changed, 4 removed, 1 failure May 14, 2025, 8:52 AM

@clairechabas
Merge branch 'main' into claire/rnd-6959-add-support-for-tabs-links-i…
73e57b5 
…n-gbo

* main:
  Use absolute URLs in sitemap.xml when pointing to sitemap-pages.xml (#3210)
@clairechabas clairechabas marked this pull request as draft May 5, 2025 09:20
@clairechabas clairechabas marked this pull request as ready for review May 5, 2025 09:55
@clairechabas clairechabas marked this pull request as ready for review May 9, 2025 15:54
@clairechabas clairechabas marked this pull request as draft May 9, 2025 15:54
@clairechabas clairechabas marked this pull request as ready for review May 9, 2025 16:15
BrettJephson
BrettJephson approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@BrettJephson BrettJephson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could maybe shave a little bit of white space off for the tab’s hash link but otherwise all good.

@clairechabas
Merge branch 'main' into claire/rnd-6959-add-support-for-tabs-links-i…
728618c 
…n-gbo

* main:
  Only resize images with supported extensions (#3229)
@clairechabas
update
d527049
@clairechabas
Merge branch 'main' into claire/rnd-6959-add-support-for-tabs-links-i…
fc39334 
…n-gbo

* main:
  Handle OpenAPI alternatives from schema.items (#3235)
  Use default value if string/number/boolean in generateSchemaExample (#3234)
@clairechabas clairechabas merged commit 08382ce into main May 14, 2025
18 of 21 checks passed
@clairechabas clairechabas deleted the claire/rnd-6959-add-support-for-tabs-links-in-gbo branch May 14, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettJephson BrettJephson BrettJephson approved these changes

@gregberge gregberge gregberge approved these changes

@emmerich emmerich Awaiting requested review from emmerich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clairechabas @BrettJephson @gregberge